mon: remove ceph-create-keys from mon startup #9345
Conversation
|
I suspect the issue is in the test suite as the failing command is: Since now the mon servers will not definitely have admin keyrings on them this could be he reason for a false positive. |
|
test this please |
|
Seems all test have past this time :) |
|
@oms4suse failed to build http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-trusty-amd64-notcmalloc/log.cgi?log=1f26a813a0ceef144afa25a86a029e67ad70c665 install: cannot stat ‘systemd/ceph-create-keys@.service’: No such file or directory |
|
@oms4suse Needs rebase |
Drop
|
@oms4suse ping |
|
Hi sage, I thought this was resolved upstream already |
|
I am back on this PR. |
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
593e51f
to
e3529e2
Compare
|
Pushed new version. |
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
e3529e2
to
f0d1450
Compare
|
Rebased to master again |
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
f0d1450
to
03feb1b
Compare
|
Rebasing to restart checks. Jenkins agent failed last time, and http request failed, both unrelated to this code base. |
|
jenkins, retest this please. |
|
seems all tests passed. |
|
@yuriw Please can you retest? |
|
Needs rebase again. |
|
Thanks Nathan I will get back to this. |
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
03feb1b
to
beb46c4
Compare
|
Rebased to master |
liewegas
changed the title
|
@yuriw let's get this merged this week for kraken. probably just needs a ceph-deploy and smoke test? |
|
Test failed but I think its unrelated. |
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
beb46c4
to
37aa8dc
Compare
|
Rebased on todays master to see if tests now pass |
|
Seems tests pass on todays master. |
|
@yuriw Please can you retest? |
|
This passes my manual ceph-deploy test. |
| @@ -809,7 +809,7 @@ rm -rf %{buildroot} | |||
| %{_bindir}/osdmaptool | |||
| %{_bindir}/ceph-run | |||
| %{_bindir}/ceph-detect-init | |||
| %{_unitdir}/ceph-create-keys@.service | |||
| %{_bindir}/ceph-client-debug | |||
There was a problem hiding this comment.
I think this line shouldn't be added here... can you remove?
ceph-create-keys should not be started on boot of mons with systemd so should not exist in the rpm. Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with upstart so should not exist in the deb. Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with upstart so should not exist in the upstart files Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with systemd so should not exist in the systemd files Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with systemd so should not exist as 'After' or 'Wants' for the ceph-mon.service Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with systemd so should not exist as 'After' or 'Wants' for the ceph-mon.service Signed-off-by: Owen Synge <osynge@suse.com>
ceph-create-keys should not be started on boot of mons with sysv init. Signed-off-by: Owen Synge <osynge@suse.com>
oms4suse
force-pushed
the
wip_remove_mon_startup_magic
branch
from
37aa8dc
to
cc441cb
Compare
|
Changes requested complete I think. |
Fixes: http://tracker.ceph.com/issues/16036