mon: PGMonitor add check only concern our self cluster command #9976
Conversation
|
jenkins test this please (no logs) |
ghost
added
|
please explain the bug you are trying to fix in the commit message. Note that I do not understand the meaning of the title of the commit message: it needs to be reworded for clarity. |
There was a problem hiding this comment.
I understand what you are trying to achieve with this patch: making sure the PGMonitor will only handle messages that target this cluster, especially in environments where there may be other ceph clusters around.
However, I am curious: how does one incur in such an issue? Unless the admin is somehow sharing ceph.conf across multiple clusters, or allowing clients from another cluster to contact this cluster, you should never hit a condition where this happens. If it does, please do let us know and how to reproduce.
In any case, it would be nice if you were to propose a few more patches for all the consumers of PaxosServiceMessage's that have an fsid, not just for those from the PGMonitor.
| @@ -699,6 +699,11 @@ bool PGMonitor::preprocess_pg_stats(MonOpRequestRef op) | |||
| return true; | |||
| } | |||
|
|
|||
| if (stats->fsid != mon->monmap->fsid) { | |||
| dout(0) << "preprocess_pg_stats on fsid " << stats->fsid << " != " << mon->monmap->fsid << dendl; | |||
There was a problem hiding this comment.
it would be nice to also print out the message that triggered this. Say,
dout(0) << __func__ << " drop message on fsid " << stats->fsid << " != " << mon->monmap->fsid << " for " << *stats << dendl;
or something. Same for the other parts where you add this check.
There was a problem hiding this comment.
@jecluis Thank you. I will change this later.
we only concern the command send to our self cluster Signed-off-by:song baisen <song.baisen@zte.com.cn>
|
@jecluis Done. |
|
@liewegas this was tested pls merge http://pulpito.ceph.com/yuriw-2017-02-06_15:38:04-rados-wip-yuri-testing_2017_2_6---basic-smithi/ added infra fix ceph/ceph: Pull Request 13279 http://pulpito.ceph.com/yuriw-2017-02-06_23:30:25-rados-wip-yuri-testing_2017_2_6---basic-smithi/ |
|
@songbaisen I see no bug number associated with this PR |
liewegas
changed the title
mon: PGMonitor add check only concern our self cluster command
we only concern the command send to our self cluster
Signed-off-by:song baisen song.baisen@zte.com.cn