Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

falsy returns undefined when undefined is not in pool #522

Open
emahuni opened this issue Feb 28, 2021 · 0 comments
Open

falsy returns undefined when undefined is not in pool #522

emahuni opened this issue Feb 28, 2021 · 0 comments

Comments

@emahuni
Copy link
Contributor

emahuni commented Feb 28, 2021

The falsey pool parameter isn't working as intended. eg:

chance.falsy({pool: [null] });

That sometimes produces undefined, not sure if it's a bug - bug or the it is trying to also use undefined as a falsy value.
emahuni added a commit to emahuni/chancejs that referenced this issue Feb 28, 2021
@emahuni
fix: falsy returns undefined when it's not in pool
ec7b62c 
fixes issue chancejs#522
it was picking undefined coz index was wrong
@emahuni emahuni mentioned this issue Feb 28, 2021
Merged
@emahuni emahuni changed the title Falsy pool param not working falsy returns undefined when undefined is not in pool Feb 28, 2021
emahuni added a commit to emahuni/chancejs that referenced this issue Feb 28, 2021
@emahuni
fix: falsy returns undefined when it's not in pool
96b9321 
fixes chancejs#522
victorquinn pushed a commit that referenced this issue Sep 2, 2021
@emahuni
fix: falsy returns undefined when it's not in pool (#523)
859e555 
fixes issue #522
it was picking undefined coz index was wrong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emahuni