Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Diagram of Sortinghat and related Components #597

Open
shanchenqi opened this issue Jan 24, 2022 · 8 comments
Open

Sequence Diagram of Sortinghat and related Components #597

shanchenqi opened this issue Jan 24, 2022 · 8 comments

Comments

@shanchenqi
Copy link

shanchenqi commented Jan 24, 2022

Hi, everyone, I am working for grimoirelab-gitee, a backend for gitee. In order to better understanding of sortinghat handling, I design a sequence diagram. Here I would like to share with you, I hope to get your help to check if this diagram is clear and any mistakes?

Copy of sortinghat-en-v3-enrich

@vchrombie
Copy link
Member

Hi @shanchenqi, thanks for all the effort!

The diagram looks really nice and it could potentially help a lot of new contributors who are trying to understand about SortingHat. I just have one doubt regarding the diagram. Have you created the diagram for the new version (under development: muggle branch) or is this related to the old version (stable and currently supported one: master branch)?

@shanchenqi
Copy link
Author

Hello,@vchrombie. Thanks for your reply. The diagram is built according to the old version(master branch). I paid attention to the Identiles load and enrich task, and find how it works with SortingHat.

@eyehwan
Copy link
Member

eyehwan commented Feb 7, 2022

Hi @vchrombie when muggle branch will be merged into main?

@vchrombie
Copy link
Member

Hi @vchrombie when muggle branch will be merged into main?

Well, that is a really difficult question to ask. We, right now, don't have an estimate of when it will happen. But, I'm sure it will happen soon.
We are working on integrating the new version with ELK, Mordred etc.

@vchrombie
Copy link
Member

Hello,@vchrombie. Thanks for your reply. The diagram is built according to the old version(master branch). I paid attention to the Identiles load and enrich task, and find how it works with SortingHat.

Okay, thanks @shanchenqi. Please let me know if you are interested to work on something similar for the new version too (muggle branch). We can add it to the docs if you can open a PR for it.

@shanchenqi
Copy link
Author

OK,@vchrombie! I will update the Sequence Diagram to the new version in the next step.

@shanchenqi
Copy link
Author

Excuse me, @vchrombie. Could I ask whether the muggle branch can work in grimorilab now?

@vchrombie
Copy link
Member

Excuse me, @vchrombie. Could I ask whether the muggle branch can work in grimorilab now?

Sorry @shanchenqi, the work is still in progress. We are in the process of integrating the new version with the other grimoirelab tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants