Remove locale dependence in parsed_apache_config test #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the problem raised in GitHub issue chizmw#5. By not relying on the locale-based error output in the test, one can then still check that the test dies as expected, and with the expected error message, however still allow the tests to run correctly on systems with a non-English locale.
chizmw
added a commit
that referenced
this pull request
Nov 1, 2015
…-locales Remove locale dependence in parsed_apache_config test
chizmw
added a commit
that referenced
this pull request
Nov 15, 2015
- Merged pull-requests from Paul Cochrane: - #6 replace NoTabsTests - #7 add missing abstracts (for dzil) - #8 add Travis config - #9 purge trailing whitespace - #10 fix POD errors - #11 update dist.ini - #12 add missing strictures - #13 remove shebang in tests - #14 fix typos in POD - #15 fix tests on non-English locales - #16 increase error severity in call handler - Resolve "[PkgVersion] no blank line for $VERSION after package" with dzil prep - add skeleton POD for methods unhelpfully empty but keeps pod-coverage tests happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the problem raised in GitHub issue #5. By not relying on the
locale-based error output in the test, one can then still check that the
test dies as expected, and with the expected error message, however still
allow the tests to run correctly on systems with a non-English locale.