Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around plugin test failures #18

Merged
merged 1 commit into from Jul 13, 2017
Merged

Conversation

zostay
Copy link

@zostay zostay commented Jul 13, 2017

I wrote a new implementation of the contributors-from-git plugin 3 years ago to work around the installation issues I found.

(Karen sent this to my fork. I'm forwarding it on to you. -- Sterling)

I wrote a new implementation of the contributors-from-git plugin 3 years ago to work around the installation issues I found.
@chizmw chizmw merged commit 479238c into chizmw:master Jul 13, 2017
@chizmw
Copy link
Owner

chizmw commented Jul 13, 2017

I'm assuming this is normal and expected:

[Git::Contributors] Warning: distribution has non-ascii characters in contributor names. META.json will be unparsable on perls <= 5.8.6 when JSON::PP is lower than 2.27300

chizmw added a commit that referenced this pull request Jul 13, 2017
 - Refactor internals to make extensible (PR #17)
 - dzil: use Git::Contributors instead of ContributorsFromGit (PR #18)
chizmw added a commit that referenced this pull request Jul 13, 2017
 - Refactor internals to make extensible (PR #17)
 - dzil: use Git::Contributors instead of ContributorsFromGit (PR #18)
@zostay
Copy link
Author

zostay commented Jul 13, 2017

@karenetheridge would know. The reason to prefer her solution, as I understand it, is because the other mod you have been using breaks dzil authordeps --missing | cpanm and the author has not responded to the bug report to fix it in for at least a couple years.

@karenetheridge
Copy link
Contributor

Yes, that's an expected warning given the conditions of the distribution and the state of the toolchain historically. I've never seen it actually cause a problem in the wild, as if META.* is not parsable, ExtUtils::MakeMaker just falls back to MYMETA.json (which is generated from the PREREQ_PM arguments in Makefile.PL).

@chizmw
Copy link
Owner

chizmw commented Jul 13, 2017

@karenetheridge - thanks! I didn't think it was likely to be a big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants