Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft code for HTTP Digest authentication implementation #53

Open
pifleo opened this issue Jan 3, 2013 · 1 comment
Open

Draft code for HTTP Digest authentication implementation #53

pifleo opened this issue Jan 3, 2013 · 1 comment

Comments

@pifleo
Copy link
Contributor

pifleo commented Jan 3, 2013

Hi,

I would like to allow opening files from Microsoft Word to authenticated users.
As Word and MS webdav clients forbidden access to server with HTTP Basic over simple HTTP (I will set SSL in production), I started to patch dav4rack for Digest authentication.

The code is available here: https://github.com/pifleo/dav4rack/compare/auth_digest and a wiki page here

It is very short and working in my apps as expected as dependencies are met.

I think it can't be integrated in the gem for the moment as it add some dependencies from actionpack:

  • action_controller/http_authentication
  • action_dispatch/request.

But If you have any advice or proposition to make it better we can try to integrate this feature.

@chrisroberts
Copy link
Owner

@pifleo This is very cool! I would agree about the actionpack dependency as I have not been too excited to add any action* or active* dependencies into dav4rack. The approach looks good and the actionpack bits may be easily swapped out. Also, at the very least, these modifications could be optionally enabled via configuration options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants