Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 support #74

Open
Matthijsy opened this issue Apr 8, 2021 · 0 comments
Open

Ruby 3.0 support #74

Matthijsy opened this issue Apr 8, 2021 · 0 comments

Comments

@Matthijsy
Copy link

I see that there hasn't been a lot of activity here, but we still use this gem to provide WebDav sync for our users. Now we would like to migrate to Ruby 3.0, however there are 2 function calls that were deprecated and are removed in ruby 3.0. It is the URI.escape and URI.unescape method. (https://github.com/chrisroberts/dav4rack/blob/master/lib/dav4rack/controller.rb#L35 and https://github.com/chrisroberts/dav4rack/blob/master/lib/dav4rack/controller.rb#L45).

I am fine with opening an PR to fix this, would you be willing to update them gem in that case? What are those two lines supposed to do? Can they be replaced with URI.encode_www_form or is it encoding an full URI (so including the domain and path). I can open an PR but need to understand it a bit more.

Would be great to hear something and see if we can make it ruby 3.0 compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant