-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eks: Don't use spot instances #32553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing unnecessary flakes. Money is not a concern so let's not bother using spot instances. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
learnitall
approved these changes
May 15, 2024
Similar to EKS, money is not a concern here so let's not bother with preemptible instances. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
/test |
tklauser
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💸
YutaroHayakawa
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
aanm
approved these changes
May 16, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 16, 2024
8 tasks
@michi-covalent Should we backport this to stable branches as well? |
oh yeah might as well. let me set backport labels 🚀 🙏 |
michi-covalent
added
needs-backport/1.13
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
May 23, 2024
15 tasks
YutaroHayakawa
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
May 23, 2024
12 tasks
YutaroHayakawa
added
the
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
label
May 24, 2024
YutaroHayakawa
removed
the
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
label
May 24, 2024
10 tasks
github-actions
bot
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
backport-pending/1.13
labels
May 25, 2024
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's causing unnecessary flakes. Money is not a concern so let's not bother using spot instances.
edit: now there are 2 commits: