Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Settings not found on request when looking up value for SUPPORT_EMAIL_ADDRESS" logs error when internal server error #7405

Open
rockycodes opened this issue May 3, 2024 · 0 comments
Labels
bug Something isn't working needs-triage bugs that have not yet been triaged

Comments

@rockycodes
Copy link
Contributor

We reference the settings value for SUPPORT_EMAIL_ADDRESS when we show the internal server error page here:

String supportEmail = settingsManifest.getSupportEmailAddress(requestHeader).get();

But the CIVIFORM_SETTINGS_ATTRIBUTE_KEY isn't set on the request at that point which is causing these warnings to show up in our logs:

"Settings not found on request when looking up value for %s", variableName));

We should either find a way to set the CIVIFORM_SETTINGS_ATTRIBUTE_KEY or find another way to reference the value for SUPPORT_EMAIL_ADDRESS so that the warnings aren't triggered.

Note: the fallback behavior works fine so this isn't broken, just annoying.

@rockycodes rockycodes added bug Something isn't working needs-triage bugs that have not yet been triaged labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage bugs that have not yet been triaged
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant