Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break dependency between Scalar Types and eligibility conditions #7437

Open
greg-hyde opened this issue May 7, 2024 · 0 comments
Open

Break dependency between Scalar Types and eligibility conditions #7437

greg-hyde opened this issue May 7, 2024 · 0 comments
Labels
bug Something isn't working needs-triage bugs that have not yet been triaged

Comments

@greg-hyde
Copy link
Contributor

Describe the bug
Right now, the eligibility conditions are tied very tightly to the set of scalars defined by Scalar.java. In one recent instance, we added new scalar types for date questions that were UI concepts only and were not stored in the database, and found that the scalar values appeared in the eligibility conditions dropdown. We probably want to use an allowlist on the EligibilityPredicateView to ensure we only allow adding eligibility conditions for scalars we explicitly want to support conditions on

@greg-hyde greg-hyde added bug Something isn't working needs-triage bugs that have not yet been triaged labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage bugs that have not yet been triaged
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant