Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the multiple-comparisons arguments #9

Open
civilstat opened this issue Feb 8, 2021 · 2 comments
Open

Refactor the multiple-comparisons arguments #9

civilstat opened this issue Feb 8, 2021 · 2 comments

Comments

@civilstat
Copy link
Owner

RankPlot() now has two arguments about multiple comparisons:
Bonferroni = c("none", "demi", "full")
and
multcomp.type = c("bonferroni", "independence")

The Bonferroni argument should be renamed to something like multcomp.scope for clarity.
This should be done in two stages -- first add a multcomp.scope argument and just deprecate the Bonferroni argument, then after a few months remove the Bonferroni argument entirely.

This also requires changing code in the vignettes.
We might as well add example plots using the Independence correction while we're at it.
And let's double-check whether the "full" corrections are correcting for (k choose 2) as I think it should, or for ((k-1) choose 2) as it says in the documentation.

@civilstat
Copy link
Owner Author

Also need to allow "none" as a multcomp.type option in RankColumnPlot() and FindSignifInColumn(), and add Adam Hall as a contributor.

@civilstat
Copy link
Owner Author

civilstat commented Jan 27, 2022

Mostly addressed by a recent commit.

But although RankColumnPlot() works, we still need to change the wrapper RankPlot() to allow multcomp.type != "demi" when plotType = "columns".

Also, we'll need to revisit this after a few version updates on CRAN have passed, and switch the Bonferroni argument from deprecated to defunct.

And still need to add example plots using the Independence correction to the vignettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant