Skip to content

Commit

Permalink
Merge branch 't/12733'
Browse files Browse the repository at this point in the history
  • Loading branch information
szymonkups committed Sep 15, 2015
2 parents cce7c45 + 98263e9 commit 47e6f7f
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -10,6 +10,7 @@ New Features:
Fixed Issues:

* [#9856](http://dev.ckeditor.com/ticket/9856): Fixed: Cannot use the native context menu together with the [Div Editing Area](http://ckeditor.com/addon/divarea) plugin. Thanks to [Mark Wade](https://github.com/mark-wade)!
* [#12733](http://dev.ckeditor.com/ticket/12733): Fixed: Radio button onChange doesn't work in IE9+. Thanks to [Iliya Kostadinov](https://github.com/iliyakostadinov)!
* [#13142](http://dev.ckeditor.com/ticket/13142): [Edge] Fixed: CTRL+A, backspace results in an empty div.
* [#13599](http://dev.ckeditor.com/ticket/13599): Fixed: Cross-editor D&D of inline widget ends up in error/artifacts.
* [#13640](http://dev.ckeditor.com/ticket/13640): [IE] Fixed: Dropping a widget outside body is not handled correctly.
Expand Down
2 changes: 1 addition & 1 deletion plugins/dialogui/plugin.js
Expand Up @@ -1290,7 +1290,7 @@ CKEDITOR.plugins.add( 'dialogui', {
*/
eventProcessors: {
onChange: function( dialog, func ) {
if ( !CKEDITOR.env.ie )
if ( !CKEDITOR.env.ie || ( CKEDITOR.env.version > 8 ) )
return commonEventProcessors.onChange.apply( this, arguments );
else {
dialog.on( 'load', function() {
Expand Down
33 changes: 33 additions & 0 deletions tests/tickets/12733/1.html
@@ -0,0 +1,33 @@
<div id="editor1">
<img alt="CKEditor logo" src="%BASE_PATH%_assets/logo.png" />
</div>

<script>
CKEDITOR.replace( 'editor1' );

CKEDITOR.on( 'dialogDefinition', function( ev ) {
var dialogName = ev.data.name,
dialogDefinition = ev.data.definition;

if ( dialogName == 'image' ) {
// Get a reference to the "Image Info" tab.
var infoTab = dialogDefinition.getContents( 'info' );
infoTab.add( {
type: 'radio',
id: 'customId',
label: 'Test Label',
title: 'Test Title',
className: 'radioClass',
required: false,
items: [
[ 'Test0', 'Test0', 'Test0' ],
[ 'Test1', 'Test1', 'Test1' ],
[ 'Test2', 'Test2', 'Test2' ]
],
onChange: function() {
console.log( 'changed' );
}
} );
}
} );
</script>
11 changes: 11 additions & 0 deletions tests/tickets/12733/1.md
@@ -0,0 +1,11 @@
@bender-tags: 4.5.3, tc
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, image

----

1. Open the console.
2. Edit the image (e.g. by double clicking it).
3. Click any of the radio buttons at the bottom.

**Expected:** On each selection change the text *changed* should be logged to the console.

0 comments on commit 47e6f7f

Please sign in to comment.