Skip to content

Commit

Permalink
Merge branch 't/12688'
Browse files Browse the repository at this point in the history
  • Loading branch information
Reinmar committed Nov 20, 2014
2 parents d789182 + a8fb1fc commit 5334245
Show file tree
Hide file tree
Showing 3 changed files with 349 additions and 171 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -21,6 +21,7 @@ Fixed Issues:
* [#12141](http://dev.ckeditor.com/ticket/12141): Fixed: List items are lost when indenting a list item with a content wrapped with a block element.
* [#12515](http://dev.ckeditor.com/ticket/12515): Fixed: Cursor is in the wrong position when undoing after adding image and typing some text.
* [#12484](http://dev.ckeditor.com/ticket/12484): [Blink/Webkit] Fixed: DOM is changed outside the editor area in certain case.
* [#12688](http://dev.ckeditor.com/ticket/12688): Improved the tests of the [styles system](http://docs.ckeditor.com/#!/api/CKEDITOR.style) and fixed two minor issues.

Other Changes:

Expand Down
12 changes: 9 additions & 3 deletions core/style.js
Expand Up @@ -471,8 +471,14 @@ CKEDITOR.STYLE_OBJECT = 3;
// matches the attribute value exactly.
// - The override definition value is a regex that
// has matches in the attribute value.
if ( attValue === null || ( typeof attValue == 'string' && actualAttrValue == attValue ) || attValue.test( actualAttrValue ) )
if ( attValue === null )
return true;
if ( typeof attValue == 'string' ) {
if ( actualAttrValue == attValue )
return true;
} else if ( attValue.test( actualAttrValue ) ) {
return true;
}
}
}
}
Expand Down Expand Up @@ -1160,7 +1166,7 @@ CKEDITOR.STYLE_OBJECT = 3;
if ( element == startPath.block || element == startPath.blockLimit )
break;

if ( me.checkElementRemovable( element ) )
if ( me.checkElementRemovable( element, true ) )
breakStart = element;
}

Expand All @@ -1170,7 +1176,7 @@ CKEDITOR.STYLE_OBJECT = 3;
if ( element == endPath.block || element == endPath.blockLimit )
break;

if ( me.checkElementRemovable( element ) )
if ( me.checkElementRemovable( element, true ) )
breakEnd = element;
}

Expand Down

0 comments on commit 5334245

Please sign in to comment.