Skip to content

Commit 6daae25

Browse files
committed
Merge branch 't/12411'
2 parents 7f82350 + e322faa commit 6daae25

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Fixed Issues:
2020
* [#12163](http://dev.ckeditor.com/ticket/12163): Fixed: Maximize plugin should abort its initialization if the [Shared Spaces plugin](http://ckeditor.com/addon/sharedspace) is initialized.
2121
* [#12398](http://dev.ckeditor.com/ticket/12398): Fixed: Maximize does not work on instance without a [title](http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-title).
2222
* [#12097](http://dev.ckeditor.com/ticket/12097): Fixed: JAWS not reading number of list options correctly in colors list box.
23+
* [#12411](http://dev.ckeditor.com/ticket/12411): Fixed: [Page Break](http://ckeditor.com/addon/pagebreak) used directly in the editable breaks the editor.
2324

2425
## CKEditor 4.4.4
2526

plugins/pagebreak/plugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
span: {
135135
match: function( element ) {
136136
var parent = element.parent;
137-
return parent && parent.name == 'div' && parent.styles[ 'page-break-after' ];
137+
return parent && parent.name == 'div' && parent.styles && parent.styles[ 'page-break-after' ];
138138
},
139139
styles: 'display'
140140
}

tests/plugins/pagebreak/pagebreak.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,22 @@
6363
editor.execCommand( 'paste', html );
6464

6565
wait();
66+
},
67+
68+
// #12411
69+
'test span as a direct child no break': function() {
70+
bender.editorBot.create( {
71+
name: 'editor2',
72+
startupData: '<span>he?</span>',
73+
config: {
74+
autoParagraph: false,
75+
extraPlugins: 'divarea'
76+
}
77+
},
78+
function( bot ) {
79+
// If we get here it means that nothing fails :)
80+
assert.pass();
81+
} );
6682
}
6783
} );
6884
} )();

0 commit comments

Comments
 (0)