Skip to content

Commit

Permalink
Merge branch 't/12411'
Browse files Browse the repository at this point in the history
  • Loading branch information
Reinmar committed Sep 15, 2014
2 parents 7f82350 + e322faa commit 6daae25
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -20,6 +20,7 @@ Fixed Issues:
* [#12163](http://dev.ckeditor.com/ticket/12163): Fixed: Maximize plugin should abort its initialization if the [Shared Spaces plugin](http://ckeditor.com/addon/sharedspace) is initialized.
* [#12398](http://dev.ckeditor.com/ticket/12398): Fixed: Maximize does not work on instance without a [title](http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-title).
* [#12097](http://dev.ckeditor.com/ticket/12097): Fixed: JAWS not reading number of list options correctly in colors list box.
* [#12411](http://dev.ckeditor.com/ticket/12411): Fixed: [Page Break](http://ckeditor.com/addon/pagebreak) used directly in the editable breaks the editor.

## CKEditor 4.4.4

Expand Down
2 changes: 1 addition & 1 deletion plugins/pagebreak/plugin.js
Expand Up @@ -134,7 +134,7 @@
span: {
match: function( element ) {
var parent = element.parent;
return parent && parent.name == 'div' && parent.styles[ 'page-break-after' ];
return parent && parent.name == 'div' && parent.styles && parent.styles[ 'page-break-after' ];
},
styles: 'display'
}
Expand Down
16 changes: 16 additions & 0 deletions tests/plugins/pagebreak/pagebreak.js
Expand Up @@ -63,6 +63,22 @@
editor.execCommand( 'paste', html );

wait();
},

// #12411
'test span as a direct child no break': function() {
bender.editorBot.create( {
name: 'editor2',
startupData: '<span>he?</span>',
config: {
autoParagraph: false,
extraPlugins: 'divarea'
}
},
function( bot ) {
// If we get here it means that nothing fails :)
assert.pass();
} );
}
} );
} )();

0 comments on commit 6daae25

Please sign in to comment.