Preventing page reload when droping on non editable elements.

ckeditor · May 29, 2015 · bfdd042 · bfdd042
1 parent fe4de43
commit bfdd042
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/plugins/clipboard/plugin.js b/plugins/clipboard/plugin.js
@@ -1341,6 +1341,20 @@
 				// Cancel native drop.
 				evt.data.preventDefault();
 
+				var target = evt.data.getTarget();
+
+				var readOnly;
+				if ( target.is && target.is( 'html' ) ) {
+					readOnly = false;
+				} else {
+					readOnly = target.isReadOnly();
+				}
+
+				// Do nothing if drop on non editable element (#13015).
+				if ( readOnly ) {
+					return;
+				}
+
 				// Getting drop position is one of the most complex part.
 				var dropRange = clipboard.getRangeAtDropPosition( evt, editor ),
 					dragRange = clipboard.dragRange;

diff --git a/plugins/widget/plugin.js b/plugins/widget/plugin.js
@@ -1,4 +1,4 @@
-/**
+/**
  * @license Copyright (c) 2003-2015, CKSource - Frederico Knabben. All rights reserved.
  * For licensing, see LICENSE.md or http://ckeditor.com/license
  */
@@ -3044,6 +3044,11 @@
 			widget.wrapper.append( container );
 		}
 
+		// Preventing page reload (#13015).
+		widget.wrapper.on( 'dragover', function( evt ) {
+			evt.data.preventDefault();
+		}, widget );
+
 		widget.wrapper.on( 'mouseenter', widget.updateDragHandlerPosition, widget );
 		setTimeout( function() {
 			widget.on( 'data', widget.updateDragHandlerPosition, widget );