Skip to content

Commit d69e345

Browse files
committed
Merge branch 't/16801' into major
2 parents 981d4a9 + 18c3a12 commit d69e345

File tree

8 files changed

+19
-20
lines changed

8 files changed

+19
-20
lines changed

.jscsrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
},
5454
"validateIndentation": {
5555
"value": "\t",
56-
"allExcept": [ "comments" ]
56+
"allExcept": [ "comments", "emptyLines" ]
5757
}
58-
}
58+
}

.jshintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222
"validthis": true,
2323

2424
"predef": [ "CKEDITOR", "assert", "arrayAssert", "bender", "JSON", "objectAssert", "resume", "sinon", "wait", "YUITest" ]
25-
}
25+
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# CKEditor 4 - The best browser-based WYSIWYG editor
22

3-
[![devDependency Status](https://david-dm.org/ckeditor/ckeditor-dev/dev-status.svg)](https://david-dm.org/ckeditor/ckeditor-dev#info=devDependencies)
3+
[![devDependencies Status](https://david-dm.org/ckeditor/ckeditor-dev/dev-status.svg)](https://david-dm.org/ckeditor/ckeditor-dev?type=dev)
44

55
This repository contains the development version of CKEditor.
66

dev/tasks/jscs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = function( grunt ) {
1515
},
1616

1717
git: function() {
18-
return tools.getGitDirtyFiles().filter( function( file ) {
18+
return tools.getGitDirtyFiles( true ).filter( function( file ) {
1919
return ( /\.js$/ ).test( file );
2020
} );
2121
}

dev/tasks/jshint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = function( grunt ) {
1515
},
1616

1717
git: function() {
18-
return tools.getGitDirtyFiles().filter( function( file ) {
18+
return tools.getGitDirtyFiles( true ).filter( function( file ) {
1919
return ( /\.js$/ ).test( file );
2020
} );
2121
}

dev/tasks/utils/tools.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,14 +96,15 @@ module.exports = {
9696
/**
9797
* Gets the list of files that are supposed to be included in the next Git commit.
9898
*
99+
* @param cachedOnly {Boolean} List only files which are staged.
99100
* @returns {String[]} A list of file paths.
100101
*/
101-
getGitDirtyFiles: function() {
102+
getGitDirtyFiles: function( cachedOnly ) {
102103
// Cache it, so it is executed only once when running multiple tasks.
103104
if ( !dirtyFiles ) {
104105
dirtyFiles = this
105106
// Compare the state of index with HEAD.
106-
.shExec( 'git diff-index --name-only HEAD' )
107+
.shExec( 'git diff-index --name-only ' + ( cachedOnly ? '--cached HEAD' : 'HEAD' ) )
107108
// Remove trailing /n to avoid an empty entry.
108109
.replace( /\s*$/, '' )
109110
// Transform into array.
@@ -125,18 +126,15 @@ module.exports = {
125126
* @returns {String} The command output.
126127
*/
127128
shExec: function( command ) {
128-
var sh = require( 'shelljs' );
129-
sh.config.silent = true;
130-
131-
var ret = sh.exec( command );
129+
var sh = require( 'shelljs' ),
130+
ret = sh.exec( command, { silent: true } );
132131

133132
if ( ret.code ) {
134133
throw new Error(
135134
'Error while executing `' + command + '`:\n\n' +
136-
ret.output
135+
ret.stdout
137136
);
138137
}
139-
140-
return ret.output;
138+
return ret.stdout;
141139
}
142140
};

gruntfile.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ module.exports = function( grunt ) {
1818
'samples/toolbarconfigurator/lib/**',
1919
'tests/adapters/jquery/_assets/**',
2020
'tests/core/dom/_assets/**',
21-
'tests/core/selection/_helpers/rangy.js'
21+
'tests/core/selection/_helpers/rangy.js',
22+
'tests/plugins/pastefromword/generated/_lib/q.js'
2223
];
2324

2425
// Basic configuration which will be overloaded by the tasks.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@
99
"benderjs-sinon": "^0.3.1",
1010
"benderjs-yui": "^0.3.2",
1111
"benderjs-yui-beautified": "0.0.5",
12-
"grunt": "^0",
12+
"grunt": "^1.0.1",
1313
"grunt-contrib-imagemin": "^1.0.0",
14-
"grunt-jscs": "^2.0.0",
14+
"grunt-jscs": "^3.0.1",
1515
"grunt-contrib-jshint": "^1.0.0",
1616
"grunt-contrib-less": "^1.0.0",
1717
"grunt-contrib-watch": "^1.0.0",
1818
"grunt-contrib-concat": "^1.0.0",
1919
"grunt-jsduck": "^1.0.1",
20-
"grunt-githooks": "^0.5.0",
20+
"grunt-githooks": "^0.6.0",
2121
"less": "^2.5.0",
22-
"shelljs": "~0.6",
22+
"shelljs": "^0.7.6",
2323
"cksource-samples-framework": "^1.0.1"
2424
},
2525
"scripts": {

0 commit comments

Comments
 (0)