Skip to content

Commit

Permalink
Merge branch 't/14312'
Browse files Browse the repository at this point in the history
  • Loading branch information
mlewand committed Apr 20, 2016
2 parents 909294e + e134858 commit eaf5716
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Expand Up @@ -5,6 +5,7 @@ CKEditor 4 Changelog

Fixed Issues:

* [#14312](http://dev.ckeditor.com/ticket/14312): Fixed: [IE] Artifact is visible after pasting of any text.
* [#11697](http://dev.ckeditor.com/ticket/11697): Fixed: It is possible to replace content with wrong letter case.
* [#13886](http://dev.ckeditor.com/ticket/13886): Fixed: Invalid handling of [`CKEDITOR.style`](http://docs.ckeditor.com/#!/api/CKEDITOR.style) instance with `styles` property by [`CKEDITOR.filter`](http://docs.ckeditor.com/#!/api/CKEDITOR.filter).
* [#14535](http://dev.ckeditor.com/ticket/14535): Fixed: CSS syntax corrections. Thanks to [mdjdenormandie](https://github.com/mdjdenormandie)!
Expand Down
8 changes: 4 additions & 4 deletions plugins/clipboard/plugin.js
Expand Up @@ -702,16 +702,16 @@
async: true,

exec: function( editor, data ) {
var fire = function( data, withBeforePaste ) {
var cmd = this,
fire = function( data, withBeforePaste ) {
data && firePasteEvents( editor, data, !!withBeforePaste );

editor.fire( 'afterCommandExec', {
name: 'paste',
command: cmd,
returnValue: !!data
} );
},
cmd = this;
};

// Check data precisely - don't open dialog on empty string.
if ( typeof data == 'string' )
Expand Down Expand Up @@ -903,7 +903,7 @@
// Transparency is not enough since positioned non-editing host always shows
// resize handler, pull it off the screen instead.
else {
pastebin.setStyle( editor.config.contentsLangDirection == 'ltr' ? 'left' : 'right', '-1000px' );
pastebin.setStyle( editor.config.contentsLangDirection == 'ltr' ? 'left' : 'right', '-10000px' );
}

editor.on( 'selectionChange', cancel, null, null, 0 );
Expand Down
10 changes: 10 additions & 0 deletions tests/tickets/14312/1.html
@@ -0,0 +1,10 @@
<div style="position: absolute;top:40px;left:100px;width:100px">Artifact would appear somewhere over here.</div>
<div style="margin-left: 1100px; position: relative">
<textarea cols="80" id="classic" name="classic" rows="10" >
<p>CKEditor test</p>
</textarea>
</div>

<script>
CKEDITOR.replace( 'classic' );
</script>
16 changes: 16 additions & 0 deletions tests/tickets/14312/1.md
@@ -0,0 +1,16 @@
@bender-ui: collapsed
@bender-tags: 4.5.9, tc, 14312
@bender-ckeditor-plugins: clipboard, contextmenu, toolbar, wysiwygarea

## Scenario

1. If your screen is too small to see both the editor and the "Artifact would appear..." text - zoom out
1. Click the "Paste" button.

### Expected result:

Artifact does not appear.

### Unexpected:

An artifact in the form of a vertical line appears.

0 comments on commit eaf5716

Please sign in to comment.