Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scrollbar appears when the container has height set to 100% #5399

Open
Comandeer opened this issue Jan 4, 2023 · 1 comment
Open
Labels
accessibility Issue related to accessibility. browser:chrome The issue can only be reproduced in the Chrome browser. browser:opera The issue can only be reproduced in the Opera browser. browser:safari The issue can only be reproduced in the Safari browser. plugin:copyformatting The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://codepen.io/Comandeer/full/GRBjMWJ

Expected result

There is no vertical scrollbar

Actual result

There is a vertical scrollbar.

Other details

  • Browser: Blink-based and Safari
  • OS: N/A
  • CKEditor version: 4.7.0+
  • Installed CKEditor plugins: copyformatting

The issue is connected with the fact that the .cke_screen_reader_only element, used for Copy Formatting notifications, has non-zero dimensions. Somehow it forces the scrollbar if the editor's container has the same height as the viewport. We should check if we could change the dimensions of the notifications element to 0 without affecting screen readers.

It could be also a good moment to align our screen reader utility class with the industry standard.

@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:chrome The issue can only be reproduced in the Chrome browser. browser:safari The issue can only be reproduced in the Safari browser. browser:opera The issue can only be reproduced in the Opera browser. plugin:copyformatting The plugin which probably causes the issue. accessibility Issue related to accessibility. labels Jan 4, 2023
@Comandeer
Copy link
Member Author

There is a proposed workaround in the ZK CKeditor issue tracker:

.cke_screen_reader_only {
    bottom: 0px;
}

It's worth checking if it's enough and does not cause any issue with screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. browser:chrome The issue can only be reproduced in the Chrome browser. browser:opera The issue can only be reproduced in the Opera browser. browser:safari The issue can only be reproduced in the Safari browser. plugin:copyformatting The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

1 participant