Add on Demand mode #183
Open
Add on Demand mode #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Aug 7, 2019
README.md
Outdated
| @@ -134,7 +134,9 @@ When creating tables you can pass specific throughput settings or stream specifi | |||
|
|
|||
| ```js | |||
| dynogels.createTables({ | |||
| 'BlogPost': {readCapacity: 5, writeCapacity: 10}, | |||
| 'BlogPost': { | |||
| billingMode: 'PAY_PER_REQUEST' | |||
There was a problem hiding this comment.
Since this part of documentation is not specifically about 'on-demand' mode, maybe leave as it was before?
There was a problem hiding this comment.
Let’s add one example for each option so the developer can see what is possible
PAY_PER_REQUEST is super convenient
This adds a new schema attribute, billingMode, which can be set to 'PROVISIONED' (the default) or 'PAY_PER_REQUEST', which causes the table to run in On Demand mode. This value can also be provided on a per-table basis to the dynogels.createTables` function.
aneilbaboo
force-pushed
the
aneil/enableOnDemand
branch
from
9fd1395
to
ef54ad4
Compare
|
Rebased on current master and addressed the comment from @rchl. |
rchl
reviewed
Jun 5, 2020
package.json
Outdated
| "aws-sdk": "^2.408.0", | ||
| "lodash": "^4.17.15", | ||
| "aws-sdk": "^2.441.0", | ||
| "lodash": "4.17.4", |
There was a problem hiding this comment.
Why downgrading lodash?
Also the aws-sdk version changed but it's not reflected in package-lock.
Should run npm i.
There was a problem hiding this comment.
Good catch. I think this was a rebase issue. I just pushed a fix.
aneilbaboo
force-pushed
the
aneil/enableOnDemand
branch
from
9717ea8
to
c5b285c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new schema attribute, billingMode, which can be set to 'PROVISIONED' (the default) or 'PAY_PER_REQUEST', which causes the table to run in On Demand mode. This value can also be provided on a per-table basis to the dynogels.createTables` function.
Fixes #182