Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

simulate et al. raise a spurious/misleading exception when inputs are exhausted #144

Open
cemerick opened this issue Mar 20, 2018 · 0 comments

Comments

@cemerick
Copy link

Example:

> simulate (register 8) [1, 2, 3]
"[8,1,2,3*** Exception: X: finite list

Absent the background/context, this output looks like something's gone wrong.

Per @christiaanb in irc:

.:christiaanb:. yeah, that's to be expected
.:christiaanb:. because in principle you could be simulating multiple clock domains, so you could have fewer or more samples on the output with regards to the input
.:christiaanb:. but perhaps we should be generating a nicer exception

Seems like a reasonable beginner contribution. I'll take a shot at a PR, perhaps.

Q: should an exception be raised at all in this case? It seems that a finite input here is a reasonable expectation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant