Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Names in fort.t File #546

Open
mandli opened this issue Nov 5, 2016 · 2 comments
Open

Inconsistent Names in fort.t File #546

mandli opened this issue Nov 5, 2016 · 2 comments

Comments

@mandli
Copy link
Member

mandli commented Nov 5, 2016

I noticed while adding another file format that the ascii routines write out nstates in place of ngrids and loops over states rather than patches. This clearly works ok but I think this confuses the role of states and patches in the code but before changing it I wanted to get some feedback as to what was intended with the number of states here. Are there plans to record the states at some point as well as patches for SharpClaw?

@ketch
Copy link
Member

ketch commented Nov 7, 2016

No concrete plans. Of course, if we ever use multiple states per patch we'll need to update all the output routines to handle that. It's probably best to change this routine to be consistent with the others as you suggest.

@mandli
Copy link
Member Author

mandli commented Nov 7, 2016

Ok, I will write up a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants