Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid labels will create invalid Metrics page #91

Open
AlexanderWells-diamond opened this issue Aug 24, 2023 · 0 comments
Open

Invalid labels will create invalid Metrics page #91

AlexanderWells-diamond opened this issue Aug 24, 2023 · 0 comments

Comments

@AlexanderWells-diamond
Copy link

If you attempt to add a label to a metric that is invalid, that label is emitted in the Metrics page.

For example, passing in a labels object of 'pv' : 'CALC\{(A%2)}(BL05J-VA-IOC-02:HEARTBEAT)', will result in an output of:
coniql_dropped_updates{pv="CALC\{(A%2)}(BL05J-VA-IOC-02:HEARTBEAT)",type="value"} 0

This sort of thing seems to violate the Escaping section of the OpenMetrics spec. I've observed the same when my Prometheus instance fails to parse the output.

I believe there just needs to be a check added to this function that performs additional validation of the label's contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant