Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port refactored beeper code from Baseflight #648

Closed
thenickdude opened this issue Mar 19, 2015 · 12 comments
Closed

Port refactored beeper code from Baseflight #648

thenickdude opened this issue Mar 19, 2015 · 12 comments

Comments

@thenickdude
Copy link
Contributor

Creating this issue to help track issues that are blocked waiting for beeper code to be ported over from upstream and progress on implementation.

Related issues:
#647 Add beep when changing flight modes
#481 Morse code beeps for failure states
#408 CLI command to play/test warning tones
#317 Beep to sound on arm/disarm

@hydra
Copy link
Contributor

hydra commented Mar 19, 2015

Thanks for opening this nick. Much appreciated.

@ethomas997
Copy link
Contributor

Is anyone currently working on this task? If not then I'll work on it and post a PR.

--ET

@thenickdude
Copy link
Contributor Author

@ethomas997 haven't heard anyone mention it on the IRC channel (I'm not working on it, at least).

@hydra
Copy link
Contributor

hydra commented Mar 22, 2015

@ethomas997 please go ahead and do this! Many thanks.

@ethomas997
Copy link
Contributor

Alright, PR is posted. http://github.com/cleanflight/cleanflight/pull/669
I've been flying this version with no issues.

--ET

@hydra
Copy link
Contributor

hydra commented Mar 25, 2015

Nice! I'll check this out.

@TadasSu
Copy link

TadasSu commented Mar 29, 2015

Hi All.
All beeps are very quiet in CleanFlight (in comparison with baseflight).
It seems that beeps in BF are way longer (maybe double the time).
Low Voltage beeps almost can not be heard (or hear the difference between low and critical alarm) when flying.
Is it possible to make them louder (longer)?

@dkisselev
Copy link
Contributor

@TadasSu Have you tried the new beeper code in #669? It'll be in CF 1.9.x and some of the sounds have been changed to be louder/closer to baseflight sounds.

@ethomas997
Copy link
Contributor

If anyone wants to try out a test hex file I've posted one here: http://www.etheli.com/CF/refactoredBeeperCode

--ET

@TadasSu
Copy link

TadasSu commented Mar 30, 2015

Thanks, I will try it :)

@ethomas997
Copy link
Contributor

Updated PR for this is here: Port of refactored beeper code 181_1 #730
As far as I know it's ready for merging.

--ET

@hydra
Copy link
Contributor

hydra commented Apr 28, 2015

done

@hydra hydra closed this as completed Apr 28, 2015
martinbudden added a commit to martinbudden/cleanflight that referenced this issue Oct 4, 2016
* Converted MSP to use streambuf
* Removed unused bufWriter_s and indRX. Minor tidy
* Added MSP_ prefix to MSP state enums
* Set outbuf size to 256
* Initialised reply cmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants