Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't assume master branch any more? #262

Open
jkroso opened this issue Aug 19, 2021 · 3 comments
Open

can't assume master branch any more? #262

jkroso opened this issue Aug 19, 2021 · 3 comments

Comments

@jkroso
Copy link

jkroso commented Aug 19, 2021

Now that github is encouraging people to call their primary branch "main" instead of "master" it probably makes sense to default to main or master rather than just master

@stephenmathieson
Copy link
Member

I had this thought when the made the master->main switch. IMO the best solution would be to lookup the repository's default branch rather than assuming anything.

@dko1905
Copy link

dko1905 commented Mar 20, 2022

Now that github is encouraging people to call their primary branch "main" instead of "master" it probably makes sense to default to main or master rather than just master
Where do they do that?

It's bad practice to change a default branch. People that have already cloned the repository will not be able to pull the latest changes after the rename. You would actively break other peoples installs.

@stephenmathieson
Copy link
Member

Where do they do that?

When you create a new repository, the default branch is main automatically (it used to be master).

It's bad practice to change a default branch. People that have already cloned the repository will not be able to pull the latest changes after the rename. You would actively break other peoples installs.

I'm not sure how/why this is relevant. We're discussing which branch we default to when installing a package (when no version is specified).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants