Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue console.log #13

Closed
zdwolfe opened this issue Jun 26, 2014 · 4 comments
Closed

Rogue console.log #13

zdwolfe opened this issue Jun 26, 2014 · 4 comments
Assignees
Labels

Comments

@zdwolfe
Copy link

zdwolfe commented Jun 26, 2014

There's a console.log in toggleKeyEvent. Old browsers don't support console.log, though I'm not sure what your list of supported browsers is, so this could be a non-issue.

@tylersticka
Copy link
Member

Just removed from the source and minified JS files. Thanks for flagging, @zdwolfe !

@tylersticka tylersticka self-assigned this Jun 26, 2014
@zdwolfe
Copy link
Author

zdwolfe commented Jun 26, 2014

Cool. Do you have a list of known supported browsers? Known unsupported browsers?

@tylersticka
Copy link
Member

It should support any browser that supports changing the type attribute of an <input> element. So far, the only browsers we've found that don't allow this are IE8 and below. The plugin includes a feature test that disables itself by default if that feature is not available.

@zdwolfe
Copy link
Author

zdwolfe commented Jun 26, 2014

Sweet, might be good for SEO to add a list of browsers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants