-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browserify require is broken when jQuery versions mismatch #39
Comments
I can confirm when using an earlier version of jQuery than what's defined in this module's |
@jeremylevy I have a potential fix pushed to the
You may also need to run Can you confirm whether or not this resolves the issue? If so, I'll go ahead and merge the branch and push this update to Thanks for your patience! |
It works! You rock! Thanks 👍 |
Great! I'll go ahead and merge and bump the version... |
@jeremylevy This fix is available in version Thanks again! |
Hello,
Just encountered a problem when requiring
hideshowpassword
using Browserify.Given that I need to support IE8, jQuery is defined as
^1.11.3
in mypackage.json
.Since you have also added jQuery as dependency, and that the two versions mismatch, the
hideshowpassword
function will be attached to your jQuery instance, instead of mine, making it unavailable from my code.Why jQuery has been added as production dependency, given that the function is attached to
$.fn
?The text was updated successfully, but these errors were encountered: