Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use six.text_type instead of unicode #28

Open
jaredlockhart opened this issue Sep 24, 2014 · 1 comment
Open

Use six.text_type instead of unicode #28

jaredlockhart opened this issue Sep 24, 2014 · 1 comment

Comments

@jaredlockhart
Copy link

Should the following two lines:

https://github.com/clouserw/tower/blob/master/tower/__init__.py#L55-L56

use six.text_type instead of unicode like here:

https://github.com/django/django/blob/master/django/utils/translation/__init__.py#L99

?

@clouserw
Copy link
Owner

Probably! I swapped it out and ran the tests and it still worked fine. I don't know a lot about six so I'm not sure when it would be a good idea to do it. Any advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants