Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jingo requirement #7

Open
davedash opened this issue Apr 26, 2012 · 3 comments
Open

Remove Jingo requirement #7

davedash opened this issue Apr 26, 2012 · 3 comments

Comments

@davedash
Copy link
Collaborator

I don't think Jingo is entirely required, but things like calling JINJA_CONFIG() make that hard... not sure what the best solution here is.

For a starter making JINJA_CONFIG optionally callable might be nice.

@fwenzel
Copy link
Collaborator

fwenzel commented Apr 26, 2012

Makes sense, generally. What do you mean with "making JINJA_CONFIG optionally callable"? doesn't it already have to be a callable for tower to work? If anything, the syntax where JINJA_CONFIG isn't a callable doesn't currently work. Right?

@clouserw
Copy link
Owner

We could try/catch around it and have sensible defaults

@davedash
Copy link
Collaborator Author

For example JINGO_CONFIG = dict() is valid for jingo, since jingo checks to see if JINGO_CONFIG is just a setting or a callable, if it's a callable it calls it.

We could use that same logic.

But I think also the idea of using some sensible defaults makes sense. We should see what those coffin folks do.

Meanwhile I'll just adopt this syntax :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants