Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: adjust hardware decoder when selecting MPCVR #2621

Open
clsid2 opened this issue Mar 2, 2024 · 8 comments
Open

ToDo: adjust hardware decoder when selecting MPCVR #2621

clsid2 opened this issue Mar 2, 2024 · 8 comments

Comments

@clsid2
Copy link
Owner

clsid2 commented Mar 2, 2024

When changing renderer to MPCVR, change hardware decoder in internal LAV Video to D3D11.
Check registry for MPCVR settings first to see if DX11 was maybe disabled by user on Win10/11.

When changing from MPCVR to VMR9/EVR change it back to DXVA2 Native?

Maybe show prompt "Would you like to optimize hardware video decoding setting for the selected video renderer?"

@NBruderman
Copy link

Sounds like a neat idea!
How about MadVR? Should we revert to DXVA2 when switching to it from MPCVR?

@clsid2
Copy link
Owner Author

clsid2 commented Mar 3, 2024

For MadVR either D3D11 or DXVA2 Copyback is best choice. So can't do anything there. I don't want to interfere with deliberate user choices. Nor I am interested in making this super complex.

@NBruderman
Copy link

So yeah, maybe each time a switch between the relevant renderes occurs, a dialog box might be the best solution if the optimal decoder is not the one chosen

@gitschab
Copy link

gitschab commented Mar 3, 2024

Thanks for this ticket, thanks to it I figured out why MadVR wouldn't work in MPC-HC on Win11 on Intel Iris XE, it was precisely because "DXVA2 (native)" is selected, and MadVR doesn't seem to work with it. Switching do D3D11 solves this. MPC-BE does this automatically, so MadVR works in it out of the box.

I'm forced to use MadVR as both EVR and MPCVR won't play 25fps videos on Win11/Iris XE smoothly, there's visible jitter/stutter (whatever this is called). MadVR plays them fine, but uses (in case of my laptop) 1W of energy more (which means approx 1 hour of playback less). I have no such problem playing 25fps videos on YouTube, VLC also seems fine. Any idea what could be causing this in MPC-HC and MPC-BE under both EVR and MPCVR?

@clsid2
Copy link
Owner Author

clsid2 commented Mar 3, 2024

MadVR supports DXVA2 just fine. It is your GPU driver which does no longer properly supports DXVA2 and other DirectX9 functionality.

This issue is not for GPU driver support. I can't help you with that.

@gitschab
Copy link

gitschab commented Mar 3, 2024

Yes, I realize it's the GPU driver. However, Iris XE has been included in more and more new PCs since 2022. I would really love to continue using MPC-HC and I bet I'm not alone. Seeing that YouTube or VLC (or even MadVR on MPC-HC/BE) work fine it looks it CAN be done/fixed on player/decoder/renderer end. Is there really nothing that you can do? :(

(Sorry for commenting on this thread, I just stumbled upon it accidentally and was just so happy that I figured out a way to get MadVR to work thanks to it, as I had no idea about decoder config)

@clsid2
Copy link
Owner Author

clsid2 commented Mar 3, 2024

Ask here for MPCVR:
https://github.com/Aleksoid1978/VideoRenderer/issues

@gitschab
Copy link

gitschab commented Mar 3, 2024

I will, thank you and once again sorry for barging in on this thread, I'm desperate (as I'm frustrated having spent a hefty amount of money on a new laptop (and I'm honestly considering returning it) only to find out that a 7-year-old laptop can play videos in MPC-HC better!)

Repository owner deleted a comment from Rikk Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants