Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot / github UI get confused if the same branch is used for multiple PRs #1605

Closed
jpata opened this issue Aug 3, 2021 · 3 comments
Closed

Comments

@jpata
Copy link
Contributor

jpata commented Aug 3, 2021

See e.g. the picture below, which is for cms-sw/cmssw#34713, but includes messages also for cms-sw/cmssw#34743. As @perrotta pointed out, both PRs use the same branch (this happens every once in a while). This means that the last "+1" and the github test status are not in sync, which can be confusing.

Screenshot 2021-08-03 at 19 14 14

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

A new Issue was created by @jpata Joosep Pata.

@Dr15Jones, @perrotta, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@jpata this is known issue. The github statuses (which you see at the end of PR) belongs to the actual commit. So if same commit is used for multiple PRs then github is going to show that status in all PRs. To avoid bot setting the final "test-approved/rejected" status , we use PR number in the status (e.g. cms/34743 and cms/34713). So once all the statuses for PR 34743 have result then bot is going to update only 34743 labels.

@smuzaffar
Copy link
Contributor

closing it as this is not in our control. This is feature of github itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants