Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root 6.12.x to get bug fix for std::unique_ptr #4501

Closed
gartung opened this issue Nov 14, 2018 · 6 comments
Closed

Update root 6.12.x to get bug fix for std::unique_ptr #4501

gartung opened this issue Nov 14, 2018 · 6 comments

Comments

@gartung
Copy link
Member

gartung commented Nov 14, 2018

Need this patch for root to handle the case of reading back a unique_ptr from the root file
root-project/root@066167e

@cmsbuild
Copy link
Contributor

A new Issue was created by @gartung Patrick Gartung.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Nov 14, 2018

Needed for cms-sw/cmssw#25239

@Dr15Jones
Copy link

@gartung CMSSW_10_4 is moving to ROOT 6.14. Could you check that the 6.14 we are already using in the ROOT_614 build contains the fix you need?

@gartung
Copy link
Member Author

gartung commented Nov 14, 2018

@Dr15Jones the branch cms/v6-14-00-patches/8e96679 does not have it yet. I think Phillipe submitted a backport request to root/v6-14-00-patches.

@gartung
Copy link
Member Author

gartung commented Nov 14, 2018

Backport PR is
root-project/root#2961

@gartung
Copy link
Member Author

gartung commented Nov 16, 2018

change to root/6-14-00-pathches

@gartung gartung closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants