Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbb: update to 44_20150728oss #2022

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Dec 8, 2015

The following includes support for AArch64 + Clang. TTB does not have
hand written assembly for atomic support. Clang provides __sync_*
builtins like GCC, thus we can fallback to builtin atomics on Clang.

This is needed, because TBB headers end up going through ROOT6 Cling
run-time (Clang-based).

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following includes support for AArch64 + Clang. TTB does not have
hand written assembly for atomic support. Clang provides `__sync_*`
builtins like GCC, thus we can fallback to builtin atomics on Clang.

This is needed, because TBB headers end up going through ROOT6 Cling
run-time (Clang-based).

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

A new Pull Request was created by @davidlt for branch IB/CMSSW_8_0_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ghost
Copy link

ghost commented Dec 8, 2015

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

-1

Tested at: f1719e6
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS
---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2022/40/summary.html

@smuzaffar
Copy link
Contributor

merge

cmsbuild added a commit that referenced this pull request Dec 9, 2015
@cmsbuild cmsbuild merged commit 2ffecd2 into cms-sw:IB/CMSSW_8_0_X/stable Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants