Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates the cms-data tag for RecoBTag-Combined #2954

Merged

Conversation

iahmad-khan
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iahmad-khan (Ijaz ahmad ) for branch IB/CMSSW_9_1_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@iahmad-khan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19127/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2954/19127/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921491
  • DQMHistoTests: Total failures: 14568
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1906750
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#18315
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19157/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e253cc9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18315/19157/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Apr 19, 2017

@iahmad-khan @smuzaffar
review of cms-sw/cmssw#18315 has converged on the part that is relevant to this external.
So, this external is good to be merged and will be needed for merging of cms-sw/cmssw#18315.

Please merge or provide a list of issues to be addressed.
Thank you.

@smuzaffar
Copy link
Contributor

+externals
@slava77, from our side all is good. So I am merging it.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_1_X/gcc530 IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#18315
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19263/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e253cc9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18315/19263/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants