-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Eigen compatibility with CUDA #4060
Improve Eigen compatibility with CUDA #4060
Conversation
- reorganise the CUDA checks, and `#include <thrust/swap.h>` when compiling CUDA device code - use `thrust::swap` instead of `std::swap` in CUDA device code - mark more functions and methods as `EIGEN_DEVICE_FUNC`
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_2_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
#include <thrust/swap.h>
when compiling CUDA device codethrust::swap
instead ofstd::swap
in CUDA device codeEIGEN_DEVICE_FUNC