Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Eigen compatibility with CUDA #4060

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 31, 2018

  • reorganise the CUDA checks, and #include <thrust/swap.h> when compiling CUDA device code
  • use thrust::swap instead of std::swap in CUDA device code
  • mark more functions and methods as EIGEN_DEVICE_FUNC

  - reorganise the CUDA checks, and `#include <thrust/swap.h>` when
    compiling CUDA device code
  - use `thrust::swap` instead of `std::swap` in CUDA device code
  - mark more functions and methods as `EIGEN_DEVICE_FUNC`
@fwyzard
Copy link
Contributor Author

fwyzard commented May 31, 2018

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 31, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28314/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4060/28314/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902278
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 1cf4105 into cms-sw:IB/CMSSW_10_2_X/gcc630 May 31, 2018
@fwyzard fwyzard deleted the IB/CMSSW_10_2_X/gcc630_eigen_update_for_CUDA branch August 28, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants