Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-L1Trigger-L1TMuon.spec #4250

Merged

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Aug 9, 2018

backport of #4249

Description: cms-data/L1Trigger-L1TMuon#15

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 9, 2018

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 9, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24237
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29752/console

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 9, 2018

-1

Tested at: f2ef0c8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24237/29752/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TCaloParamsESProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TCaloParamsWriter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TStage1Layer2Producer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TCaloStage2ParamsESProducer.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TStage2CaloLayer2Comp.cc: In member function 'bool L1TStage2CaloLayer2Comp::compareSums(const edm::Handle >&, const edm::Handle >&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TStage2CaloLayer2Comp.cc:716:42: error: variable 'dataIt' set but not used [-Werror=unused-but-set-variable]
   l1t::EtSumBxCollection::const_iterator dataIt = dataCol->begin(currBx);
                                          ^~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-08-08-2300/src/L1Trigger/L1TCalorimeter/plugins/L1TStage2CaloLayer2Comp.cc:717:42: error: variable 'emulIt' set but not used [-Werror=unused-but-set-variable]
   l1t::EtSumBxCollection::const_iterator emulIt = emulCol->begin(currBx);
                                          ^~~~~~


@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 9, 2018

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#24237

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29924/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@mrodozov
Copy link
Contributor

as pointed here #4249 (comment)
this PR only adds new files. Merging it to test cms-sw/cmssw#24237

@mrodozov
Copy link
Contributor

+externals

@mrodozov mrodozov merged commit 6231c03 into IB/CMSSW_10_2_X/gcc700 Aug 20, 2018
@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4250/29924/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2893368
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2893175
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@smuzaffar smuzaffar deleted the backport-IB_CMSSW_10_2_X_gcc700-4249 branch August 28, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants