update TBB to 2019_U1

[smuzaffar]

New version 2019_U1 of TBB is available now.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30956/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30973/console

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 20c3f5a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4415/30973/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4415/30973/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2995443
• DQMHistoTests: Total failures: 172
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2995074
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

@Dr15Jones , any objection on updating this for 10.4.X?
@fabiocos , should we be concerned by tese comparison differences?

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@smuzaffar they are all in L1T that looks not very reproducible, and whose code was further updated yesterday morning. Let's retry once more, although I would say there is no connection with this PR

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31001/console

[davidlange6]

we should really consider 1) deciding that this is a known feature of current L1 code, so there is no need to recheck it again and again, and 2) get the experts to prioritize fixing it (perhaps by not merging requested PRs..)

…

On Oct 12, 2018, at 9:27 AM, Fabio Cossutti ***@***.***> wrote: @smuzaffar they are all in L1T that looks not very reproducible, and whose code was further updated yesterday morning. Let's retry once more, although I would say there is no connection with this PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fabiocos]

I have already urged them to look into this, I agree that this needs to become a priority

[davidlange6]

yes, I agree - its a many months old problem...probably now means irreproducibility in production releases

…

On Oct 12, 2018, at 9:35 AM, Fabio Cossutti ***@***.***> wrote: I have already urged them to look into this, I agree that this needs to become a priority — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Dr15Jones]

Yes, please do the update.

[fabiocos]

@Dr15Jones I will let finish the test, and schedule the merge for next IB this evening

[cmsbuild]

-1

Tested at: 20c3f5a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4415/31001/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testNumba had ERRORS
---> test testImports had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4415/31001/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2995443
• DQMHistoTests: Total failures: 69
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2995177
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

the unit test failure has been observed in the IB as well and looks independent on this PR. DQM changes seem also unrelated.

[fabiocos]

merge