Update ONNX Runtime to v1.0.0 #5346
Conversation
|
A new Pull Request was created by @hqucms (Huilin Qu) for branch IB/CMSSW_11_0_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
|
The tests are being triggered in jenkins. |
|
Pull request #5346 was updated. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
| %define github_user cms-externals | ||
| Source: git+https://github.com/%{github_user}/%{n}.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&submodules=1&output=/%{n}-%{realversion}.tgz | ||
|
|
||
| BuildRequires: cmake ninja zlib python3 | ||
| Requires: eigen protobuf | ||
| Requires: protobuf |
There was a problem hiding this comment.
@hqucms , yes it is not needed as onnxruntime uses eigen internally i.e. non of the onnxruntime public headers include eigen. So removing it is correct. We need to be careful when onnxruntime public headers starts using eigen. In that case we have to make sure that onnxruntime and cmssw use the same eigen version.
There was a problem hiding this comment.
@smuzaffar Thank you very much for confirming that!
|
@smuzaffar I think it would be helpful to have the python package available to CMS users as well, but I have not figured out how to build the python wheel in the CMS environment. Would you mind taking a look, or point me to some examples? |
|
Comparison is ready Comparison Summary:
|
|
Pull request #5346 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
similar to the earlier version of this PR, I think that it can be merged first (not coupled with the CMSSW PR). |
Based on the v1.0.0 release, plus the modification in #5259.
v1.0.0 is not compatible with the eigen version we have -- given that eigen is a header-only library without any binaries, there is no runtime dependency on eigen, I think it should be fine to let ONNX Runtime use a different version (shipped as a git submodule).
@smuzaffar Could you please create a new branch in https://github.com/cms-externals/onnxruntime/?