Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Herwig to v7.2.1, and add patch to fix crash when reading lhe… #6472

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Upgrade Herwig to v7.2.1, and add patch to fix crash when reading lhe… #6472

merged 1 commit into from
Dec 24, 2020

Conversation

Dominic-Stafford
Copy link
Contributor

Backport of #6462 for use in UL production

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_10_6_X/gcc820.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Dec 1, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_10_6_X/gcc820 to IB/CMSSW_10_6_X/gcc700 December 1, 2020 17:02
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 6a4d101
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11235/summary.html
CMSSW: CMSSW_10_6_X_2020-12-01-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11235/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214376
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 29 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Dec 5, 2020 •
edited
Loading

@Dominic-Stafford , should this go in CMSSW_11_2_X too? If yes then can you please open a PR for IB/CMSSW_11_2_X/master

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11346/summary.html
CMSSW: CMSSW_10_6_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11346/summary.html
CMSSW: CMSSW_10_6_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc700

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214377
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 29 edm output root files, 34 DQM output files

@Dominic-Stafford
Copy link
Contributor Author

Hi, I wasn't planning on doing this for 11_2 as I don't believe it's used in any MC production campaigns, but I can easily do this if you feel it would be useful?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11418/summary.html
CMSSW: CMSSW_10_6_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11418/summary.html
CMSSW: CMSSW_10_6_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc700

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214376
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 29 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor

test parameters:

  • workflows=511.0

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d99b8/11734/summary.html
CMSSW: CMSSW_10_6_X_2020-12-15-2300/slc7_amd64_gcc700

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9d99b8/511.0_QCD_Pt-30_13TeV_aMCatNLO_herwig7+QCD_Pt-30_13TeV_aMCatNLO_herwig7+HARVESTGEN

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214376
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 29 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov mrodozov merged commit c6b3eae into cms-sw:IB/CMSSW_10_6_X/gcc700 Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dominic-Stafford @cmsbuild @mrodozov @smuzaffar