Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0.X] Use same soruces for jemalloc and jemalloc-debug #7399

Merged
merged 2 commits into from Oct 20, 2021

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Oct 19, 2021

backport of #7396
fixes cms-sw/cmssw#35729
None

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Oct 19, 2021

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the title Use same soruces for jemalloc and jemalloc-debug [12.0.X] Use same soruces for jemalloc and jemalloc-debug Oct 19, 2021
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a5fff/19751/summary.html
COMMIT: ac4d09e
CMSSW: CMSSW_12_0_X_2021-10-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7399/19751/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 20, 2021

+externals
@qliphy , @perrotta feel free to include it for next 12.0.X release. This is just a technical update. Default jemalloc version remains same i.e. 5.2.1 . This only makes sure that we use same jemalloc version for jemalloc-debug

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Thank you @smuzaffar for the technical update that synchronizes the sources for jemalloc also in 12_0
  • Next 12_0_X release will be a full release

@cmsbuild cmsbuild merged commit 6be7b39 into IB/CMSSW_12_0_X/master Oct 20, 2021
@smuzaffar smuzaffar deleted the backport-IB_CMSSW_12_0_X_master-7396 branch October 26, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants