Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Do not create python/package symlink to src/package/python #7865

Merged
merged 2 commits into from
May 16, 2022

Conversation

smuzaffar
Copy link
Contributor

There was a long pending request to not generate init.py under src tree (https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/1894.html ). New build rules implement this and now it not only generate any init.py file but also still allows developers to create/modify and use src/Package/python/*.py files without re-running scram build. New build rules has been tested in special PY_X IBs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #7865 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51086b/24696/summary.html
COMMIT: 47e0348
CMSSW: CMSSW_12_4_X_2022-05-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7865/24696/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 476 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697377
  • DQMHistoTests: Total failures: 1040
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696315
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_4_X/master to IB/CMSSW_12_5_X/master May 16, 2022 08:27
@smuzaffar smuzaffar merged commit c9f354e into IB/CMSSW_12_5_X/master May 16, 2022
This was referenced May 17, 2022
@smuzaffar smuzaffar deleted the smuzaffar-patch-3 branch May 18, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants