Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set COMPILER_HOST env variables #8087

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Do not set COMPILER_HOST env variables #8087

merged 1 commit into from
Sep 15, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 14, 2022 •
edited
Loading

Move the COMPILERHOST definition in rocm tool ( where it is needed)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_6_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8087 was updated.

@smuzaffar smuzaffar changed the title do not set COMPILER_PATH/HOST env variables Do not set COMPILER_PATH/HOST env variables Sep 14, 2022
fwyzard
fwyzard reviewed Sep 14, 2022
View reviewed changes
scram-tools.file/tools/rocm/env.sh Outdated
@@ -0,0 +1,3 @@
#!/bin/bash -e
export COMPILER_HOST=$(gcc -dumpmachine)
export COMPILER_PATH=${GCC_ROOT}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this set the path to what it is at runtime (after the installation and cmsrel ...) or what it was when the external itself was built ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the path will be relocated at install time (just it it is done for other toolfiles)

Copy link
Contributor Author

@smuzaffar smuzaffar Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is only used at build time and the @COMPILER_PATH@ in scram-tools.file/tools/rocm/rocm.xml is replaced with the value of $COMPILER_PATH. At install time , we relocate all toolfiles

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8087 was updated.

@cmsbuild
Copy link
Contributor

Pull request #8087 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb6792/27539/summary.html
COMMIT: df28c50
CMSSW: CMSSW_12_6_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8087/27539/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar smuzaffar changed the title Do not set COMPILER_PATH/HOST env variables Do not set COMPILER_HOST env variables Sep 15, 2022
@cmsbuild
Copy link
Contributor

Pull request #8087 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 650517d into IB/CMSSW_12_6_X/master Sep 15, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb6792/27547/summary.html
COMMIT: c3b7036
CMSSW: CMSSW_12_6_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8087/27547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618326
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618293
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild cmsbuild mentioned this pull request Sep 15, 2022
Merged
@smuzaffar smuzaffar deleted the fix-compiler-path branch September 22, 2022 06:23
@smuzaffar smuzaffar restored the fix-compiler-path branch September 22, 2022 06:23
@smuzaffar smuzaffar deleted the fix-compiler-path branch September 22, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @fwyzard