Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT 6.26 in CMSSW master #8345

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

iarspider
Copy link
Contributor

Align with rootnext branch

Align with rootnext branch
@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider iarspider requested a review from smuzaffar March 2, 2023 10:31
@smuzaffar smuzaffar changed the title Update ROOT in master Update ROOT 6.26 in CMSSW master Mar 2, 2023
@smuzaffar
Copy link
Contributor

its is a version update, so better to run the tests with full_cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/30986/summary.html
COMMIT: 4556832
CMSSW: CMSSW_13_1_X_2023-03-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8345/30986/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsHcalRecHitSoA.so
>> Checking EDM Class Transients in libCUDADataFormatsHcalDigi.so
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc11/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAnalysisDataFormatsSUSYBSMObjects.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Version for src/CUDADataFormats/PortableTestObjects/src/classes_def.xml in libCUDADataFormatsPortableTestObjects.so
>> Checking EDM Class Transients in libAlignmentCocoaFit.so


@iarspider
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31005/summary.html
COMMIT: 4556832
CMSSW: CMSSW_13_1_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8345/31005/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31005/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31005/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 171 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529672
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31027/summary.html
COMMIT: 4556832
CMSSW: CMSSW_13_1_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8345/31027/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31027/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ee11a/31027/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 151 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529674
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

looks good to go in 13.1.X

@smuzaffar smuzaffar merged commit 5c4c66e into IB/CMSSW_13_1_X/master Mar 3, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@iarspider , can you please disable ROOT626 IBs now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants