Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpaka to pickup fixes for C++20 and alpaka::Vec [13.1.x] #8647

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 14, 2023

Update alpaka to pick up fix for c++20 (backport #8567).
Minimal backport of fixes and updates to alpaka::Vec (backport #8645).

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

backport #8567
backport #8645

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86a6b0/34261/summary.html
COMMIT: a9b5f82
CMSSW: CMSSW_13_1_X_2023-08-13-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8647/34261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3186917
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40086
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40063
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 6 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@perrotta @rappoccio feel free to include it for next 13.1.x release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit da314d6 into cms-sw:IB/CMSSW_13_1_X/master Aug 15, 2023
@fwyzard fwyzard deleted the IB/CMSSW_13_1_X/master_alpaka_backport branch December 20, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants