Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong / Missing consumes call in #1206 #1279

Closed
ktf opened this issue Nov 1, 2013 · 4 comments
Closed

Wrong / Missing consumes call in #1206 #1279

ktf opened this issue Nov 1, 2013 · 4 comments

Comments

@ktf
Copy link
Contributor

ktf commented Nov 1, 2013

I suspect #1206 is missing some consumes tag somewhere. @acaudron @deguio, can you look at it? It happens in step 3 of workflow 4.6:ù

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-01-0200/pyRelValMatrixLogs/run/4.6_MinimumBias2010A+MinimumBias2010A+RECOSKIM+HARVESTD/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIM+HARVESTD.log

----- Begin Fatal Exception 01-Nov-2013 06:29:50 CET-----------------------
An exception of category 'BadToken' occurred while
   [0] Processing run: 138924 lumi: 1 event: 1572
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module BTagPerformanceAnalyzerOnData/'pfbTagAnalysis'
Exception Message:
A get using a EDGetToken with the C++ type 'edm::AssociationVector,std::vector,edm::RefToBase,unsigned int,edm::helper::AssociationIdenticalKeyReference>' was made using a token with a value 1702130277 which is beyond the range used by this module.
 Please check that the variable is being initialized from a 'consumes' call from this module.
 You can not share EDGetToken values between modules.
----- End Fatal Exception -------------------------------------------------
@acaudron
Copy link

acaudron commented Nov 1, 2013

Hi,
I think I get the problem.
This is an indirect effect from moving the booking the histograms from the constructor to the beginRun.
Basically we are filling a vector of inputTag for the taggers we want to look at using push_back. When running on several runs, the vector increase each time (the original code was supposed to be ran only one time). The error rise as we use the size of this vector to run over the tagger list in the analyser (loop on which we do the getByToken).

I will try to fix now.
Adrien

@acaudron
Copy link

acaudron commented Nov 1, 2013

I have fixed the problem.
Now what should I do? an new pull request for the fix?
Thanks
Adrien

@ktf
Copy link
Contributor Author

ktf commented Nov 1, 2013

yes, please.

@acaudron
Copy link

acaudron commented Nov 2, 2013

#1297

ktf added a commit that referenced this issue Nov 2, 2013
DQM fix -- Fix issue #1279 related to consumes migration for BTag DQM.
@ktf ktf closed this as completed Nov 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants