TrackMerger dead assignment: hit2 = hit => his = hit2

[slava77]

#17511 (review)

Static analyzer points out that hit2 = hit; is a dead assignment.
Based on the PRINT content, it looks like the code should be hit = hit2;

[cmsbuild]

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@cvuosalo,@slava77 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

@makortel @VinInn
it looks like the "bug" is still there in
https://github.com/cms-sw/cmssw/blob/CMSSW_9_2_4/RecoTracker/FinalTrackSelectors/plugins/TrackMerger.cc#L165-L167

[perrotta]

@VinInn @boudoul

Still there even in 940:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_4_0/RecoTracker/FinalTrackSelectors/plugins/TrackMerger.cc#L165-L167

I wonder if that code/method is ever used...

[VinInn]

it just saved an invalid hit instead of a pretended better one, not a big harm...

[VinInn]

addressed in #21279

[perrotta]

+1
Fixed with #21279, now merged in 10_0_X
Thank you @VinInn

[cmsbuild]

This issue is fully signed and ready to be closed.