Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching phase-0 deepNN b-taggers to phase-1 training #18443

Closed
slava77 opened this issue Apr 22, 2017 · 6 comments
Closed

switching phase-0 deepNN b-taggers to phase-1 training #18443

slava77 opened this issue Apr 22, 2017 · 6 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2017

#18315 has left out the phase-0 deepNN b-taggers using old (apparently 80X-based) training.
Based on discussion in that PR, more effort is needed to check the behavior for this data taking period.

An unwanted side-effect includes complications in configuration.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2017

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 22, 2017

assign reconstruction

@mverzett @imarches

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented May 24, 2019

@mverzett @kskovpen
in RecoBTag/Combined/python/pfDeepCSVJetTags_cfi.py in 106X we are still using RecoBTag/Combined/data/DeepFlavourNoSL.json for Run1 and 2016

I wanted to check if this is still a correct choice even for the UL rereco.
Please clarify.
Thank you.

@mverzett
Copy link
Contributor

@slava77 , yes, for Phase0 detector configuration is still the correct model to use.
Thanks for the thorough checks!

@slava77
Copy link
Contributor Author

slava77 commented Dec 3, 2019

I'm closing this as obsolete or "will not fix" case.

@slava77 slava77 closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants