Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence or fix HGC validation warnings/errors #21129

Open
slava77 opened this issue Nov 2, 2017 · 18 comments
Open

silence or fix HGC validation warnings/errors #21129

slava77 opened this issue Nov 2, 2017 · 18 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Nov 2, 2017

Based on logs from 20034 in the short matrix e.g. in CMSSW_10_0_X_2017-11-01-2300/
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_10_0_X_2017-11-01-2300/slc6_amd64_gcc630/-GenuineIntel/matrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

  1. http://cmslxr.fnal.gov/source/Validation/HGCalValidation/plugins/HGCalRecHitValidation.cc?v=CMSSW_9_4_0_pre3#0143 prints info messages as warnings "Event 1 with 559 total and 559 used recHits"
  2. "no HepMCProduct found" in HGCalSimHitValidation should be configured to use generatorSmeared
  3. "No PHGCalInfo" in HGCGeometryValidation: the input produced by SimG4HGCalValidation in the SIM step is apparently missing. This can be fixed at source or HGCGeometryValidation can be made to skip
@slava77
Copy link
Contributor Author

slava77 commented Nov 2, 2017

assign upgrade,dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

New categories assigned: dqm,upgrade

@kmaeshima,@vanbesien,@kpedro88,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 2, 2017

attn: @bsunanda

@kpedro88
Copy link
Contributor

@bsunanda please address this

@bsunanda
Copy link
Contributor

I am reviewing the HGCalValidation package right now and will take care of these.

@slava77
Copy link
Contributor Author

slava77 commented Mar 8, 2018

@bsunanda @kpedro88
is this issue still unresolved?
Please clarify.

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 8, 2018

I think #21734 addresses at least some of this, I hope @bsunanda can confirm.

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 5, 2018

@bsunanda can you confirm if all of these messages have been removed?

@kpedro88
Copy link
Contributor

kpedro88 commented Jan 3, 2019

@bsunanda ping

1 similar comment
@kpedro88
Copy link
Contributor

@bsunanda ping

@fioriNTU
Copy link
Contributor

@kpedro88 @bsunanda any news on this?

@bsunanda
Copy link
Contributor

Just working on this. Shall submit the PR for master soon

@bsunanda
Copy link
Contributor

Wondering if this needs to be back propagated?

@fioriNTU
Copy link
Contributor

fioriNTU commented Mar 1, 2019

@bsunanda thanks for the prompt action, however I see in the PR conparison that no signficant change in the logs is seen, I was expecting a large change in the logs ... I may be wrong. Anyway, checking the PR it looks clearly to kill printouts.

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 5, 2019

+upgrade

@smuzaffar
Copy link
Contributor

Do we need any more fixes for this issue?

@jfernan2
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants