Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL local reco improvement for drifting QPLL channels #21135

Open
slava77 opened this issue Nov 2, 2017 · 8 comments
Open

HCAL local reco improvement for drifting QPLL channels #21135

slava77 opened this issue Nov 2, 2017 · 8 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Nov 2, 2017

see discussion in #20986
In Run-1 we had some channels that did not lock to the central BX timing properly

  • M0 reco for these had a broader integration window
  • M2, which defines the default definition of energy, by construction fits only to one pulse in a selected BX of interest, which can be wrong for these channels.

The idea is to capture the energy correctly for the drifting channels. Some options could be

  • modify M2 to integrate OOT pulses for these channels
  • return the "best of" M2 and M0 for these channels

From Dec 7 or so: there is one more PR that modified the behavior of reco in these channels #21651

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

@slava77 to whom should this be assigned?

@slava77
Copy link
Contributor Author

slava77 commented Nov 2, 2017

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented Dec 11, 2017

Just to update: From Dec 7 or so: there is one more PR that modified the behavior of reco in these channels #21651

@smuzaffar
Copy link
Contributor

@slava77 , has #23568 addressed/fixed this issue?

@slava77
Copy link
Contributor Author

slava77 commented Sep 16, 2021

@slava77 , has #23568 addressed/fixed this issue?

no, not really.
considering that this is only a Run-1 problem, this issue is slowly getting to a "will not fix" state

@slava77
Copy link
Contributor Author

slava77 commented Sep 16, 2021

@slava77 , has #23568 addressed/fixed this issue?

no, not really.
considering that this is only a Run-1 problem, this issue is slowly getting to a "will not fix" state

@cms-sw/hcal-dpg-l2
please comment if there is still a plan to do something special for these channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants