New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BoundaryPlane and friends #21637
Comments
A new Issue was created by @davidlange6 David Lange. @davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction |
@namapane |
Both, in fact. These were intended to be the internals of the STEP propagator, with the idea that magnetic volumes would know their boundary surface and each of these surfaces would know what volumes were present on the other side, so that propagation would not need a global search for the volume at each iteration. However, this plan never took shape because (a) we obtained a very satisfactory speedup by optimizing global search and using a cache for the volume search and (b) somebody you possibly know (!) volunteered to implement a fast and efficient propagator with a less ambitious design. |
Remove BoundaryPlane and friends (follow up to #21637 )
+1 done in #23022 . This is merged in the master and is available from 10_2_0_pre2 |
This issue is fully signed and ready to be closed. |
as discussed in #21558 this code looks to be unused (and its not new)
The text was updated successfully, but these errors were encountered: