Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BoundaryPlane and friends #21637

Closed
davidlange6 opened this issue Dec 4, 2017 · 7 comments
Closed

Remove BoundaryPlane and friends #21637

davidlange6 opened this issue Dec 4, 2017 · 7 comments

Comments

@davidlange6
Copy link
Contributor

as discussed in #21558 this code looks to be unused (and its not new)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

A new Issue was created by @davidlange6 David Lange.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Dec 4, 2017

@namapane
please take a look
the Boundary{Plane,Surface} classes are in MagneticField/VolumeGeometry
Are these a part of still incomplete development or are they now obsolete?

@namapane
Copy link
Contributor

namapane commented Dec 4, 2017

Both, in fact. These were intended to be the internals of the STEP propagator, with the idea that magnetic volumes would know their boundary surface and each of these surfaces would know what volumes were present on the other side, so that propagation would not need a global search for the volume at each iteration. However, this plan never took shape because (a) we obtained a very satisfactory speedup by optimizing global search and using a cache for the volume search and (b) somebody you possibly know (!) volunteered to implement a fast and efficient propagator with a less ambitious design.
Realistically I see no chance we ever get back on implementing this design; it was a cool idea, but life is short.

cmsbuild added a commit that referenced this issue Apr 21, 2018
 Remove BoundaryPlane and friends (follow up to #21637 )
@slava77
Copy link
Contributor

slava77 commented Apr 30, 2018

+1

done in #23022 . This is merged in the master and is available from 10_2_0_pre2

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants